Skip to content

fix: proper error msg for incorrect bridge chainids #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: mock-l1-chainid
Choose a base branch
from
Draft

fix: proper error msg for incorrect bridge chainids #594

wants to merge 1 commit into from

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Feb 10, 2025 •
edited
Loading

Describe your changes

Please review prerequisite PR -> #596

If a user incorrectly specifies a bridge tx from holesky -> mainnet mev-commit chain, etc. they will now have a more descriptive error message

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@shaspitz shaspitz marked this pull request as draft February 11, 2025 04:16
@shaspitz shaspitz force-pushed the validate-bridge-chain-ids branch from 93afa14 to f97a677 Compare February 11, 2025 04:18
@shaspitz shaspitz changed the base branch from main to mock-l1-chainid February 11, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloknerurkar aloknerurkar aloknerurkar approved these changes

@mrekucci mrekucci Awaiting requested review from mrekucci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaspitz @aloknerurkar