-
Notifications
You must be signed in to change notification settings - Fork 233
Fix typescript types for ESM import #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The closer I look at this, the more I don't understand what the tool is upset about, frankly. I don't know that we should merge this just to satisfy the tool if the tool is potentially wrong. |
1533e2c to
eda21e8
Compare
| "description": "EventEmitter3 focuses on performance while maintaining a Node.js AND browser compatible interface.", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this allows TypeScript to resolve the types file automagically based on extension substitution from the chosen entrypoint, apparently.
|
as it turns out, the issues reported by this tool actually have nothing to do with #277, lol. |
|
Does this work with old versions of TypeScript? |
|
Looks like support for |
|
Thank you. |
Good to see that this repo is still being maintained by someone. |
|
Any chance we can get a release including this merged fix @lpinca ? Without I'm currently forced to either install it from
|

Fixes another one of the issues reported by "Are The Types Wrong?":
Before:
After:
