[howdy-beta] Rebase to d3ab993#5
Conversation
ykshek
commented
Jun 24, 2025
- Rebased to d3ab99382f88f043d15f15c1450ab69433892a1c
- Removed polkit patch from 3.0.0-2 as that is now merged in Release 3.0.0 boltgolt/howdy#1023,
- Moved "fix python path" to meson, due to Remove use of Environment Python boltgolt/howdy#904 being merged in Release 3.0.0 boltgolt/howdy#1023
|
Only the last two are important, the other commits are just a result of me trying to get things working without actually knowing how things work |
When that happens, you should amend commits, or squash them. See Rewriting history. Please squash to a single commit and make sure the commit message is clear. E.g: |
|
|
|
Oh boy what have I done |
|
|
No, please update this PR. You can squash the commits by rebasing as in the manual I linked previously. Change the commit message or a commit with |
|
Alright, should be all fixed now! |
|
great, thank you! I noticed you signed your commits previously. The current one isn't. If you want to resign them you can do that as follows: Amending a commit with I want to build and check some things before merging. I'll do that tonight. |
|
Ah, the previous commit was done on the github website editor, that's why it was automatically signed. I couldn't sign it because I simply don't have a key to sign the commit with. The commit became no longer signed since I amended and forced pushed them.
|
1. Rebase to d3ab993 2. Removed polkit patch from 3.0.0-2 as that is now merged, 3. Delete howdy-beta/0001-fix-polkit.patch 4. Moved "fix python path" to meson
|
Finally got around to setting up the keys and signing it, apologies for the long wait! |
|
No worries, I was just a bit too busy to look into it! Thanks for your work 🙂 |