feat: migrate deploy action to App/Deployment API surface#1
Open
kristof-siket wants to merge 1 commit into
Open
feat: migrate deploy action to App/Deployment API surface#1kristof-siket wants to merge 1 commit into
kristof-siket wants to merge 1 commit into
Conversation
Bump @prisma/compute-sdk 0.16.0 -> 0.34.0 and @prisma/management-api-sdk 1.24.0 -> 1.49.0, and update scripts/deploy.ts to the renamed App/Deployment SDK (appId, destroyOldDeployment, onDeployment*/ onOldDeployment* callbacks, deploymentId/deploymentEndpointDomain/ appEndpointDomain result fields). The pinned 0.16.0 SDK called the deprecated /v1/compute-services and /v1/versions Management API endpoints; 0.34.0 calls /v1/apps and /v1/deployments. This drains the action's remaining traffic off the deprecated surface ahead of its removal. The action's public inputs and outputs (compute-service-id, destroy-old-version, version-id, version-endpoint-domain, service-endpoint-domain) are unchanged; only the SDK calls behind them move to the new surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
prisma/compute-deployis one of the last callers of the deprecated Prisma Compute Management API endpoints (/v1/compute-services*+/v1/versions*), which are slated for removal (domain-model rename, Linear PRS-90 / milestone M6-PR4). Axiom traffic analysis traced the residual deprecated traffic to this action: it pinned@prisma/compute-sdk@0.16.0, which calls only the old surface. The action's own smoke workflows (smoke-deploy-default,smoke-deploy-prebuilt) plus the demo deploys that consume it keep the old endpoints warm.project-compute's SDK itself was already migrated to/v1/apps+/v1/deployments(project-compute #98) and published as@prisma/compute-sdk@0.34.0. This PR just moves the action onto that release.What changed
@prisma/compute-sdk0.16.0 → 0.34.0,@prisma/management-api-sdk1.24.0 → 1.49.0.scripts/deploy.ts: updated to the renamed SDK API (breaking rename in #98):deploy({ serviceId, destroyOldVersion })→deploy({ appId, destroyOldDeployment })onVersionCreated/onOldVersion*/onCleanupDanglingVersion*→onDeploymentCreated/onOldDeployment*/onCleanupDanglingDeployment*{ versionId, versionEndpointDomain, serviceEndpointDomain }→{ deploymentId, deploymentEndpointDomain, appEndpointDomain }Behind the scenes this switches the calls from
/v1/compute-services*+/v1/versions*to/v1/apps*+/v1/deployments*.Public contract preserved
The action's inputs (
compute-service-id,destroy-old-version, …) and outputs (version-id,version-endpoint-domain,service-endpoint-domain) are intentionally unchanged, so no consumer workflow needs edits. The existingcps_-prefixed service ids are accepted asappId. Renaming the action's own input/output vocabulary is out of scope for this change.Verification
bun run check:types— clean (the SDK is fully typed end-to-end, so a green typecheck confirms every method/callback/field name matches the new surface).bunx biome check scripts/deploy.ts— clean.create-deployment.sh,update-deployment-status.sh) only callapi.github.com;deploy.tswas the sole Management API caller.smoke-deploy-*workflows on merge tomain.🤖 Generated with Claude Code