Skip to content

chore(cli): read custom-domain appId instead of deprecated computeServiceId#103

Merged
kristof-siket merged 1 commit into
mainfrom
chore/custom-domain-appid
Jun 29, 2026
Merged

chore(cli): read custom-domain appId instead of deprecated computeServiceId#103
kristof-siket merged 1 commit into
mainfrom
chore/custom-domain-appid

Conversation

@kristof-siket

Copy link
Copy Markdown
Contributor

The management API now returns appId on the custom-domain response and has deprecated computeServiceId (an equal-valued alias). This points the CLI at the new field so it no longer consumes the deprecated one.

Changes

  • Bump @prisma/management-api-sdk1.46.0 (the version that exposes appId on the domain response).
  • normalizeDomainRecord (app-provider.ts) and toAppDomainSummary (controllers/app.ts) now read domain.appId instead of domain.computeServiceId.
  • The CLI's own DomainRecord / AppDomainSummary field is renamed computeServiceIdappId.

⚠️ Output note

AppDomainSummary is serialized in --json output for app domain add/show/retry, so this renames that field in the JSON output (computeServiceIdappId). The value is unchanged (same prefixed id). The human-readable output never showed this field. If we'd rather keep computeServiceId in --json for backward-compat (emit both), that's a small tweak — flagging for the call.

Validation

tsc 0 · full CLI suite 555 passing · biome clean.

🤖 Generated with Claude Code

…viceId

The management API now returns `appId` on the custom-domain response and has
deprecated `computeServiceId` (an equal-valued alias). Bump the SDK to 1.46.0
(which exposes `appId`) and point the CLI at the new field:

- normalizeDomainRecord / toAppDomainSummary read `domain.appId`
- the CLI's own DomainRecord / AppDomainSummary field is renamed
  `computeServiceId` → `appId` (note: this renames the field in `--json` output
  for `app domain add/show/retry`; the value is unchanged)

The CLI no longer consumes the deprecated API field.

tsc 0; full CLI suite 555 passing; biome clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 91da6355-b453-46af-a94a-80699e6e51f6

📥 Commits

Reviewing files that changed from the base of the PR and between e9666a6 and 273efac.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • packages/cli/package.json
  • packages/cli/src/controllers/app.ts
  • packages/cli/src/lib/app/app-provider.ts
  • packages/cli/src/types/app.ts
  • packages/cli/tests/app-controller.test.ts
  • packages/cli/tests/app-presenter.test.ts
  • packages/cli/tests/app-provider.test.ts

Summary by CodeRabbit

  • Bug Fixes
    • Domain-related CLI output now uses the app identifier consistently, improving add/show/remove/retry/wait command results.
    • Custom domain handling has been aligned with the current app identifier format for better reliability.
  • Chores
    • Updated a CLI dependency to a newer version.

Walkthrough

The PR renames the domain identifier field computeServiceId to appId across the CLI codebase. The DomainRecord and RawDomainRecord interfaces, AppDomainSummary type, listComputeServiceDomains helper, normalizeDomainRecord mapping, and toAppDomainSummary controller function are all updated. Test fixtures in app-controller, app-presenter, and app-provider tests are updated to match. The @prisma/management-api-sdk dependency is also bumped from ^1.44.0 to ^1.46.0.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main CLI change from computeServiceId to appId for custom domains.
Description check ✅ Passed The description is directly related to the changeset and accurately describes the API field migration and JSON output impact.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/custom-domain-appid
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/custom-domain-appid

Comment @coderabbitai help to get the list of available commands.

@kristof-siket
kristof-siket merged commit 3b9621a into main Jun 29, 2026
10 checks passed
@kristof-siket
kristof-siket deleted the chore/custom-domain-appid branch June 29, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant