chore(cli): read custom-domain appId instead of deprecated computeServiceId#103
Merged
Conversation
…viceId The management API now returns `appId` on the custom-domain response and has deprecated `computeServiceId` (an equal-valued alias). Bump the SDK to 1.46.0 (which exposes `appId`) and point the CLI at the new field: - normalizeDomainRecord / toAppDomainSummary read `domain.appId` - the CLI's own DomainRecord / AppDomainSummary field is renamed `computeServiceId` → `appId` (note: this renames the field in `--json` output for `app domain add/show/retry`; the value is unchanged) The CLI no longer consumes the deprecated API field. tsc 0; full CLI suite 555 passing; biome clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Summary by CodeRabbit
WalkthroughThe PR renames the domain identifier field 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The management API now returns
appIdon the custom-domain response and has deprecatedcomputeServiceId(an equal-valued alias). This points the CLI at the new field so it no longer consumes the deprecated one.Changes
@prisma/management-api-sdk→ 1.46.0 (the version that exposesappIdon the domain response).normalizeDomainRecord(app-provider.ts) andtoAppDomainSummary(controllers/app.ts) now readdomain.appIdinstead ofdomain.computeServiceId.DomainRecord/AppDomainSummaryfield is renamedcomputeServiceId→appId.AppDomainSummaryis serialized in--jsonoutput forapp domain add/show/retry, so this renames that field in the JSON output (computeServiceId→appId). The value is unchanged (same prefixed id). The human-readable output never showed this field. If we'd rather keepcomputeServiceIdin--jsonfor backward-compat (emit both), that's a small tweak — flagging for the call.Validation
tsc 0 · full CLI suite 555 passing · biome clean.
🤖 Generated with Claude Code