feat(schema-engine-cli): add support for engine: 'classic' in Prisma Config file
#5645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amodel_to_connector" to bypass the fact that "psl::ValidatedSchema" isn't cloneable
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the engine: 'classic' configuration in Prisma Config files by introducing a --datasource CLI flag to the schema-engine-cli that accepts a JSON-encoded object to override datasource URL-like attributes from the PSL datasource block.
Key changes:
- Add
--datasourceCLI parameter for JSON-encoded datasource URL overrides - Update engine state initialization to accept and apply datasource URL overrides
- Refactor datasource handling to support URL override functionality
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| schema-engine/cli/src/main.rs | Adds CLI parameter for datasource URL overrides and updates engine initialization |
| schema-engine/core/src/state.rs | Updates EngineState to accept datasource URL overrides and apply them during initialization |
| schema-engine/core/src/rpc.rs | Updates RpcApi constructor to pass through datasource URL overrides |
| schema-engine/core/src/lib.rs | Adds debug logging and refactors configuration handling |
| schema-engine/cli/Cargo.toml | Adds psl dependency for DatasourceUrls type |
| psl/psl/src/lib.rs | Exports DatasourceUrls type |
| psl/psl-core/src/lib.rs | Exports DatasourceUrls type |
| psl/psl-core/src/configuration/env_vars.rs | Adds deprecation comment for StringFromEnvVar |
| psl/psl-core/src/configuration/datasource.rs | Defines DatasourceUrls struct and adds override method to Datasource |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WASM Query Engine File Size
WASM Query Compiler File Size
|
CodSpeed Performance ReportMerging #5645 will not alter performanceComparing Summary
|
…L override in commands like "db pull", "migrate dev", etc
jkomyno
commented
Oct 13, 2025
jacek-prisma
approved these changes
Oct 13, 2025
jkomyno
deleted the
feat/add-support-for-engine-classic-in-prisma-config
branch
jkomyno
added a commit
to prisma/prisma
that referenced
this pull request
Oct 14, 2025
This PR: - closes [TML-1332](https://linear.app/prisma-company/issue/TML-1332/prisma-config-alternative-to-url-directurl-shadowdatabaseurl) - this PR depends on prisma/prisma-engines#5645. --------- Co-authored-by: jkomyno <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
engine?: 'js' | 'classic'prisma#28266--datasourcetoschema-engine-cli, which is a JSON-encoded object used to override PSL'sdatasourceURL-like attributes