TML-2527: remove in-repo CipherStash extension#650
Merged
wmadden-electric merged 1 commit intoMay 31, 2026
Conversation
…TML-2527)
The CipherStash extension has moved to CipherStash's own repository.
This commit removes the in-repo copy and all associated artifacts.
Removed directories:
- packages/3-extensions/cipherstash/
- examples/cipherstash-integration/
- projects/cipherstash-integration/ (on-disk project close-out)
- test/integration/test/authoring/parity/cipherstash-encrypted-{bigint,boolean,date,double,json,string}/
ADRs 207/212/213/214/215 are retained as historical records; they describe
design decisions the integration validated and are referenced by durable
architecture docs.
On-disk project closed out: all content under projects/cipherstash-integration/
was transient planning and spec artifacts with no durable content outside the
already-committed ADRs and framework-gaps.md analysis.
Signed-off-by: Will Madden <madden@prisma.io>
Contributor
|
Important Review skippedToo many files! This PR contains 165 files, which is 15 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (14)
📒 Files selected for processing (165)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
size-limit report 📦
|
@prisma-next/extension-author-tools
@prisma-next/mongo-runtime
@prisma-next/family-mongo
@prisma-next/sql-runtime
@prisma-next/family-sql
@prisma-next/extension-arktype-json
@prisma-next/middleware-cache
@prisma-next/mongo
@prisma-next/extension-paradedb
@prisma-next/extension-pgvector
@prisma-next/extension-postgis
@prisma-next/postgres
@prisma-next/sql-orm-client
@prisma-next/sqlite
@prisma-next/target-mongo
@prisma-next/adapter-mongo
@prisma-next/driver-mongo
@prisma-next/contract
@prisma-next/utils
@prisma-next/config
@prisma-next/errors
@prisma-next/framework-components
@prisma-next/operations
@prisma-next/ts-render
@prisma-next/contract-authoring
@prisma-next/ids
@prisma-next/psl-parser
@prisma-next/psl-printer
@prisma-next/cli
@prisma-next/cli-telemetry
@prisma-next/emitter
@prisma-next/migration-tools
prisma-next
@prisma-next/vite-plugin-contract-emit
@prisma-next/mongo-codec
@prisma-next/mongo-contract
@prisma-next/mongo-value
@prisma-next/mongo-contract-psl
@prisma-next/mongo-contract-ts
@prisma-next/mongo-emitter
@prisma-next/mongo-schema-ir
@prisma-next/mongo-query-ast
@prisma-next/mongo-orm
@prisma-next/mongo-query-builder
@prisma-next/mongo-lowering
@prisma-next/mongo-wire
@prisma-next/sql-contract
@prisma-next/sql-errors
@prisma-next/sql-operations
@prisma-next/sql-schema-ir
@prisma-next/sql-contract-psl
@prisma-next/sql-contract-ts
@prisma-next/sql-contract-emitter
@prisma-next/sql-lane-query-builder
@prisma-next/sql-relational-core
@prisma-next/sql-builder
@prisma-next/target-postgres
@prisma-next/target-sqlite
@prisma-next/adapter-postgres
@prisma-next/adapter-sqlite
@prisma-next/driver-postgres
@prisma-next/driver-sqlite
commit: |
wmadden
approved these changes
May 31, 2026
wmadden-electric
deleted the
tml-2527-remove-cipherstash-extension-from-pn-repo
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a glance
This is a removal PR.
@prisma-next/extension-cipherstashwas an in-repo incubation of CipherStash's encrypted-field support. That integration now lives in CipherStash's own repository (published as the partner package@cipherstash/prisma-next), so the in-repo copy is redundant.The bulk of the diff is those deletions. The parts worth a reviewer's eyes are the handful of files that referenced cipherstash and now point at a live in-repo extension instead.
Decision
Remove the in-repo CipherStash extension, its example app, and its authoring-parity fixtures, and close the on-disk
projects/cipherstash-integration/planning project. Where docs and tests used cipherstash as their example extension, repoint them topgvector/paradedb, which remain in-repo.The decision to wind the in-repo work down is already reflected in Linear — the substantive tickets were cancelled on 2026-05-27.
Why
CipherStash was always an exemplar: a real third-party extension we incubated in-repo to prove the extension surface. Now that it ships from CipherStash's own repository, keeping a second copy here means dual maintenance and a misleading "first-party" signal for an extension that is, in fact, external. Deleting it leaves
pgvectorandparadedb— both genuinely in-repo — as the example extensions the docs and tests lean on.What's adjusted (not just deleted)
test/integration/package.json— dropped the@prisma-next/extension-cipherstashdependency; lockfile regenerated viapnpm install.test/integration/test/cli.migration-plan-ref-aware.e2e.test.ts— migrated from the cipherstash control pack to pgvector; still exercises extension-space seeding.scripts/check-upgrade-coverage.test.mjs— two fixture paths repointed topgvector.packages/3-targets/3-targets/postgres/test/snapshot-read-shapes.test.ts— removed now-dead cipherstash path-exclusion filters.packages/3-extensions/pgvector/src/contract.ts— dropped a comment referencing a deleted cipherstash file.pgvector/paradedbas the live extension example (subsystems 6 & 7, contract-spaces-overhead, the migration domain README, and several skills).What's deliberately kept
README.md's@cipherstash/prisma-nextlink — the extension lives there now.'cipherstash'sample space-id string literals in framework/migration tests — they're sample names, not package references.docs/reference/framework-gaps.md— references only the external codebase, not deleted paths.projects/*dirs.Verification
pnpm build(65/65) ·pnpm lint:deps(0 violations) — green.pnpm test:packages/pnpm test:integrationgreen except pre-existing local-infra flakiness (missing CLI binary + DB connection under parallel load) unrelated to this deletion; the modified e2e passes in isolation. CI is the gate.Alternatives considered
pgvector/paradedb— so a reader can follow the example to real in-repo code.Closes TML-2527.