Skip to content

Conversation

kayandra
Copy link

@kayandra kayandra commented Jun 20, 2025

This PR introduces support for two new id generators

Checklists

  • I've included backing tests for the generators.
  • I've update the vscode extension and language server. see feat(language-server): Suggestions/completions for typeid and ksuid language-tools#1886
  • For typeid's it'd be better for the type returned to be of type TypeID<'prefix'> instead of string. I may need some guidance on this.
  • Show suggestions for prefix based on the model name name in lowercase. i.e model User {} gets typeid(<user>) as suggestion.

P.S if there's something important I have to do to get these merged please let me know.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kayandra kayandra changed the title Support KSUID and Prefixed TypeID feat(client-engine-runtime): Support KSUID and Prefixed TypeID Jun 20, 2025
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! This is a good start, however this also needs:

@kayandra
Copy link
Author

kayandra commented Jul 5, 2025

Alright, I'll make the changes and push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for typeid

3 participants