[codex] Fix Safari grid horizontal scrolling#1512
Open
gregory-boch-prisma wants to merge 1 commit intomainfrom
Open
[codex] Fix Safari grid horizontal scrolling#1512gregory-boch-prisma wants to merge 1 commit intomainfrom
gregory-boch-prisma wants to merge 1 commit intomainfrom
Conversation
|
Compute preview deployed. Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes horizontal scrolling in Prisma Studio wide grids on Safari by keeping the shared table wrapper as a plain overflow scroller instead of making the scroll container itself a flex formatting context.
Root Cause
The grid table already pins its width to the computed column sizes. The wrapper around that table also had
display: flex, which Chromium tolerated, but Safari can fail to expose the expected horizontal scroll range for wide table content inside an overflow flex container.Changes
flex items-startfrom the shared table wrapper.min-w-0so the overflow container can shrink inside Studio's flex layout while preserving horizontal overflow.overflow-autoscroller.Validation
pnpm test:ui ui/studio/grid/DataGrid.layout.test.tsxpnpm demo:ppgathttp://localhost:4310using the seededpublic.all_data_typestable.double_col,inet_col).Note:
pnpm test:ui ui/studio/grid/DataGrid.virtualization.test.tsxcurrently fails before assertions in this checkout becauseglobalThis.localStoragelacksgetItemin that test environment. The focused layout test includes a local mock and passes.