fix: allow query on columns with space in name #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Do you think this would be straightforward to check in a test? |
Sure! Thank you very much~ |
|
I was bitten by this issue today when attempting to do a bulk insert to a table having columns with spaces in the name. Is this just waiting on a test to be merged? I can take a crack at it if @Geo-W isn't able to. The code should probably also be updated to handle the case where the column name contains the |
|
Is any progress here? I got same problem. The fix is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As sql server allows empty space in column name, make it adaptable to columns with space in its name.