Skip to content

Implement MultiSubnetFailover #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement MultiSubnetFailover #378

wants to merge 4 commits into from

Conversation

srkaj
Copy link

@srkaj srkaj commented Apr 11, 2025 •
edited
Loading

This builds on PR #357 to fix #337.

  • MultiSubnetFailover is a recongnized configuration flag.
  • ... with a public getter in Config.
  • The SqlBrowser implementations (tokio, smol, and async-std) handles multi-subnet failover correctly.
  • Note: When the actual network connection is done by some other crate, that crate must handle multi-subnet failover when creating the socket. See Implement multi-subnet-failover. kardeiz/bb8-tiberius#27 .

@srkaj srkaj changed the title Multi subnet failover Implement MultiSubnetFailover Apr 11, 2025
tylerclendenin and others added 3 commits April 11, 2025 15:04
@tylerclendenin @srkaj
Add support for MultiSubnetFailover connection property
db08159 
When the MultiSubnetFailover=Yes property is added to the connection string, the TCP connection should be attempted for each resolved IP address in parallel rather than in sequence. This creates a race where the first connection to be established wins and becomes the target server.

https://learn.microsoft.com/en-us/sql/relational-databases/native-client/features/sql-server-native-client-support-for-high-availability-disaster-recovery?view=sql-server-ver15#connecting-with-multisubnetfailover
@srkaj
Implement multi_subnet_failover for tokio.
bf27687
@srkaj
Add a config getter for the multi-subnet-failover flag
f803c23
@srkaj srkaj force-pushed the multi-subnet-failover branch from 36c051a to 2732e81 Compare April 11, 2025 13:05
@srkaj
More multi_subnet_failover implementation.
0d1660f 
Now better implemented in sql_brower with tokio, async_std and smol.
@srkaj srkaj force-pushed the multi-subnet-failover branch from 2732e81 to 0d1660f Compare April 11, 2025 13:16
@srkaj srkaj mentioned this pull request Apr 11, 2025
Draft
@srkaj srkaj mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Support for MultiSubnetFailover when using a High Availability Group

2 participants

@srkaj @tylerclendenin