fix: DR-7576 Update statistic imports/exports to use on other repos#7610
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new public export for the Statistic component, updates MDX examples to import Statistic from the package root, and bumps the package version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/eclipse/content/design-system/molecules/statistic.mdx`:
- Line 6: The import is using a default import for Statistic but the package
re-exports it as a named export; change the import to a named/destructured
import (use { Statistic }) from the package that re-exports it (refer to the
exported symbol Statistic in index.ts and the original statistic module) so the
module import matches the export form.
- Line 29: The example currently uses a default import "import Statistic from
\"@prisma/eclipse\";" but the package exports Statistic as a named export;
update the import to use a named import for the Statistic symbol (i.e., change
the import line so it imports { Statistic } from the module) so the
documentation example aligns with the actual export.
- Line 99: The example import currently uses a default import for Statistic;
update it to a named import by changing the import line to use { Statistic }
(i.e., import { Statistic } from "@prisma/eclipse";) so the docs match the
actual exported symbol and usage of Statistic.
- Line 45: The documentation example currently uses a default import "import
Statistic from \"@prisma/eclipse\";" but the component is exported as a named
export; change the import to a named import (use { Statistic }) in the example
so the example matches the actual export; update the import statement that
mentions Statistic to use curly braces around Statistic and leave the module
specifier unchanged.
- Line 13: The documentation example currently uses a default import for
Statistic ("import Statistic from \"@prisma/eclipse\"") which is incorrect;
update the example to use a named import by importing the exported Symbol
(Statistic) as a named import from "@prisma/eclipse" so consumers copying the
example will match the library's exported API and avoid import errors.
- Line 75: The documentation example uses a default import for Statistic but the
library exports it as a named export; update the import statement that currently
references Statistic (from "@prisma/eclipse") to use a named import (i.e.,
import { Statistic } ...) so the example matches the actual exported symbol and
update any other occurrences in this file that use the same default-import
pattern.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ea394211-5378-49f6-9761-84ab768f04df
📒 Files selected for processing (3)
apps/eclipse/content/design-system/molecules/statistic.mdxpackages/eclipse/package.jsonpackages/eclipse/src/components/index.ts
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Summary by CodeRabbit
New Features
Documentation
Chores