UMB (unified Markov binary) format import + export#267
Merged
Conversation
Use -importmodel model.umb or -exportmodel model.umb,
or the format=umb option for either switch.
For a textual view of the UMB, use -exportmodel model.umbt
or options format=umb,text.
Switch -test:umb triggersa round-trip export/import test.
Other coder changes:
* ExplicitModelImporter knows if its reading exact models
* New ModelAccess interface to provide a unified view on all model types
Use ModelAccess.wrap(Model) to create one
* ModelExportOptions has showLabels and showRewards options
* format={explicit,umb} option for -importmodel
So complain if e.g. is-state-initial.bin is not multiple of 8 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
-importmodel model.umbor-exportmodel model.umb,or the
format=umboption for either switch.For a textual view of the UMB, use
-exportmodel model.umbtor options
format=umb,text.Switch
-test:umbtriggers a round-trip export/import test.Other code changes:
ExplicitModelImporterknows if its reading exact modelsNew
ModelAccessinterface to provide a unified view on all model typesUse
ModelAccess.wrap(Model)to create oneModelExportOptionshasshowLabelsandshowRewardsoptionsformat={explicit,umb}option for-importmodel