feat: add tally result added event #2819
Conversation
JohnGuilding
requested review from
0xmad,
NicoSerranoP and
vplasencia
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| previous.value = _tallyResult; | ||
|
|
||
| emit ResultAdded(_voteOptionIndex, _tallyResult); |
There was a problem hiding this comment.
I like the idea but should the event be emitted on addTallyResults rather than addTallyResult ? My understanding is that the coordinator calls once addTallyResults and then addTallyResult is called multiple times internally.
I feel it might be more helpful to get an event after all results have been tallied rather than on every execution of partial results tallying 😊
There was a problem hiding this comment.
addTallyResults won't be called once. It can be called multiple times.
There was a problem hiding this comment.
@0xmad so is it better to emit the event in addTallyResult or in addTallyResults?
There was a problem hiding this comment.
Better to use it in addTallyResult to use it simplier with subgraph.
Description
Adds an event to the
addTallyResultfunction to make it easier to retrieve information on completed tallies. For example, pulling the data for a subgraph.Additional Notes
Related issue(s)
Confirmation
Important
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.