Open
Conversation
NicoSerranoP
requested changes
Apr 22, 2026
Member
There was a problem hiding this comment.
Looks good! The only priority question I have is why are we reducing property definitions and in some cases deleting property options?
I can see some reasons in this PR: #165 . My main concern was KYT because it is used for compliance:
- KYC: know your user information (name, phone, nationality. etc.)
- POI: your address is not in a sanctioned list
- KYT: your address has not interacted with sanctioned/malicious addresses?
| `cache: read=${usage.cache_read_input_tokens ?? 0} write=${usage.cache_creation_input_tokens ?? 0} miss=${usage.input_tokens}`, | ||
| ); | ||
|
|
||
| if (process.env.DEBUG_RESEARCH) { |
Member
There was a problem hiding this comment.
Should we add this DEBUG_RESEARCH env variable to the example file? I know it is an internal tool but that way we know what options we have (normal, debug, etc)
| let toolInput: { value?: string; insufficient_data: boolean } | null = null; | ||
|
|
||
| for (const block of response.content) { | ||
| if (block.type === "tool_use" && block.name === "record_evaluation") { |
Member
There was a problem hiding this comment.
what is the difference between "tool_use" and "record_evaluation"?
| { | ||
| name: "Asset privacy", | ||
| group: "Privacy", | ||
| description: |
Member
There was a problem hiding this comment.
Why are we deleting the N/A explainers around the different properties?
| "Proof of innocence (POI) / ASP", | ||
| "Selective disclosure", | ||
| "KYC/KYB", | ||
| "KYT", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Restructure the research script into a multi-phase flow using Claude code skills:
scripts/research-config.ts./research-sources <id>in Claude Code to writescripts/research-cache/<id>.json.pnpm run research <id>to writesrc/data/evaluations/<id>.json./review-evaluation <id>to check against the rules inscripts/research-prompts.ts.Above steps are composed into single skill:
/evaluate-protocol <id>This reduces token usage significantly since the API is used only for citation feature.
/research-sourcesdiscovers URLs and writesscripts/research-cache/{id}.json,scripts/research-protocol.tsreads the cache, fetches each URL once, and calls the Anthropic API per property to get citationsrecord_evaluation). Separating the two outputs gives the Citations API a clean text channel to attach source quotes to. The rule changes such as guidance on paraphrasing meant that citation feature stopped working, this changes makes citations more robustresearch-prompts.tsresearch-prompts.ts: reframe Cryptographic verifiability, fix Number of secrets minimum, add Selective-disclosure carveout to CROSS_CHECK_RULES, tighten WRITING/VALUE_FORMAT/PROPERTY rulesresearch-config.ts: add context field to ProtocolConfig and add Nullmask/Houdiniswap/Mirage etc entries with documentation andsourceUrlsSkills were generated by claude and are added in next PR