Skip to content

chore: resolve non-breaking client security advisories #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DibranMulder wants to merge 1 commit into from
Closed

chore: resolve non-breaking client security advisories #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 70 additions & 57 deletions client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@
"write-file-webpack-plugin": "^4.5.1"
},
"overrides": {
"trim": "^1.0.1"
"trim": "^1.0.1",
"serialize-javascript": "^7.0.5",

@dobby-coder dobby-coder Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serialize-javascript@^7.0.5 is more aggressive than the advisory requires. GHSA-76p7-773f-r4q5 (the relevant RCE/XSS advisory) is fixed in serialize-javascript@>=6.0.0. Pinning to ^7.0.5 adds an engines: node>=20 constraint with no extra security benefit; ^6.0.0 would clear the advisory with a smaller blast radius and looser engine requirements. The production Dockerfile uses node:lts-alpine so the bump works today, but the override has no security upside over v6.

"tar": "^7.5.16"

@dobby-coder dobby-coder Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tar@^7.5.16 is a major version bump across the only consumer here — cacache@15 declares tar@^6.0.2. tar v7 ships meaningful API/behavior changes from v6 (engines bumped to node>=18, dependency overhaul, new minipass major). Build passing does not guarantee that cacache's runtime caching paths still behave correctly under tar v7. If a 6.x release covers the advisory (e.g. ^6.2.1), prefer that; if v7 is required, please confirm cacache's caching paths were smoke-tested, not just npm run build.

}
}
Loading