Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten storage access status algorithm steps #24

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

cfredric
Copy link
Collaborator

@cfredric cfredric commented Jan 9, 2025

This doesn't change behavior, but it flattens the algorithm's steps and makes the semantics re: permissions policy more explicit. (It also avoids invoking Should request be allowed to use feature? unless really necessary.)


Preview | Diff

@cfredric cfredric self-assigned this Jan 9, 2025
@cfredric
Copy link
Collaborator Author

cfredric commented Jan 9, 2025

@sandormajor does this make sense to you?

Copy link
Contributor

@sandormajor sandormajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I actually have LGTM rights, thanks for adding me :)

@cfredric cfredric merged commit af5a7b3 into main Jan 9, 2025
1 check passed
@cfredric cfredric deleted the status_fix branch January 9, 2025 21:02
github-actions bot added a commit that referenced this pull request Jan 9, 2025
SHA: af5a7b3
Reason: push, by cfredric

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants