Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Add Azure support#9

Open
takuro-sato wants to merge 4 commits into
privacysandbox:mainfrom
KenGordon:add-azure-support
Open

Add Azure support#9
takuro-sato wants to merge 4 commits into
privacysandbox:mainfrom
KenGordon:add-azure-support

Conversation

@takuro-sato

@takuro-sato takuro-sato commented Jan 23, 2024

Copy link
Copy Markdown

Adding Azure support

This PR is adding support for enabling deployment of Bidding and Auction Services on Azure.

Azure Privacy Sandbox architecture: https://1drv.ms/w/s!AmI-86sms1pYqJ5Uqgo5Qv2Ynmrcmw?e=BDC8BH
(We'll make a PR for the document in https://github.com/privacysandbox/protected-auction-services-docs/tree/main in future)

Now B&A services can fetch private and public HPKE keys from an Azure KMS, specifically designed to support the B&A services, and handle test requests.

To try this changes locally, please visit here.

The PR for data-plane-shared-libraries repository: privacysandbox/data-plane-shared-libraries#1

Changes

  • Add Azure support
    • Add Azure configurations. e.g. --platform=azure (for Bazel), kAzure (C++ enum value).
    • Add Azure scripts and configuration files for production/packaging
    • Update some test cases to add test coverage for kAzure.

TODOs for future PRs

  • Add scripts to Deploy B&A services to Azure

Co-authored-by: Dominic Ayre <dominicayre@microsoft.com>
Co-authored-by: Joe Powell <joepowell@microsoft.com>
Co-authored-by: Kapil Vaswani <kapilv@microsoft.com>
Co-authored-by: Ken Gordon <Ken.Gordon@microsoft.com>
Co-authored-by: Mahati Chamarthy <mahati.chamarthy@microsoft.com>
Co-authored-by: Ronny Bjones <ronny.bjones@microsoft.com>
@google-cla

google-cla Bot commented Jan 23, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment on lines +112 to +114
return config_entries_map_.contains(name);
return config_entries_map_.contains(name) &&
config_entries_map_.at(name) != kEmptyValue;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change included in the previous PR #7.

Comment on lines -89 to +92
google::scp::cpio::PrivateKeyVendingEndpoint primary, secondary;
google::scp::cpio::PrivateKeyVendingEndpoint primary;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file includes changes included the previous PR #7.
They are necessary here to test the other changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants