fix: prevent duplicate suite evaluation in Mobilize#186
Merged
Conversation
## What Add a dedup guard in addEvaluationSuite to silently skip duplicate CatalogId registrations, and add a break in Mobilize's inner loop to stop after the first matching suite per catalog. ## Why The private addEvaluationSuite method appended unconditionally, so repeated AddEvaluationSuite calls with the same catalog ID would register duplicate suites. The Mobilize inner loop then evaluated and appended all of them, causing duplicate results. ## Notes - Both issues are defense-in-depth since the public API guards against duplicates via referenceCatalogs uniqueness, but direct construction (e.g. in tests) could trigger the duplicate path - The dedup guard in addEvaluationSuite uses a linear scan, which is fine given the small number of suites in practice - The break in Mobilize enforces one-suite-per-catalog-ID semantics; if multi-suite-per-catalog is ever needed, this would need revisiting Signed-off-by: jmeridth <jmeridth@gmail.com>
eddie-knight
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a dedup guard in addEvaluationSuite to silently skip duplicate CatalogId registrations, and add a break in Mobilize's inner loop to stop after the first matching suite per catalog.
Why
The private addEvaluationSuite method appended unconditionally, so repeated AddEvaluationSuite calls with the same catalog ID would register duplicate suites. The Mobilize inner loop then evaluated and appended all of them, causing duplicate results.
Notes
Testing
TestEvaluationOrchestrator_AddEvaluationSuite_DeduplicatesCatalogId: calls AddEvaluationSuite twice with the same catalog ID, verifies only one suite is registeredTestEvaluationOrchestrator_Mobilize_BreaksAfterMatch: manually constructs two suites with the same CatalogId, verifies Mobilize only evaluates and appends the first onego vet ./...,go test ./...,golangci-lint run ./...)