Skip to content

fix: pin GitHub Actions to commit SHAs to prevent supply-chain attacks#187

Merged
jmeridth merged 1 commit intoprivateerproj:mainfrom
vinayada1:sha-fix
Apr 4, 2026
Merged

fix: pin GitHub Actions to commit SHAs to prevent supply-chain attacks#187
jmeridth merged 1 commit intoprivateerproj:mainfrom
vinayada1:sha-fix

Conversation

@vinayada1
Copy link
Copy Markdown
Contributor

@vinayada1 vinayada1 commented Apr 3, 2026

Replaces mutable version tags with immutable commit SHA references for all first-party GitHub Actions (actions/checkout, actions/setup-go, actions/upload-artifact) across 4 workflow files. Dependabot will handle ongoing updates.

Signed-off-by: Vinaya Damle <vinayada1@users.noreply.github.com>
@vinayada1 vinayada1 requested a review from a team as a code owner April 3, 2026 20:24
@github-actions github-actions bot added the fix label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement, thanks @vinayada1

nacking for caution, as @jmeridth or I will need to verify every SHA manually prior to merge (complaints may be issued to GitHub who allow malicious commits to be affiliated with official repos)

@jmeridth
Copy link
Copy Markdown
Member

jmeridth commented Apr 3, 2026

Thank you for doing this. I agree with this PR but for historical context these actions have immutable releases. So the content at those tags can't change. Hence them not being a priority but this is the better "visible" practice.

@jmeridth jmeridth requested a review from eddie-knight April 3, 2026 23:50
@jmeridth jmeridth merged commit 6af8aaf into privateerproj:main Apr 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants