fix: remove raw vars from config trace log to prevent token leak#190
Merged
jmeridth merged 1 commit intoprivateerproj:mainfrom Apr 7, 2026
Merged
Conversation
The Trace call in NewConfig was passing the raw vars map as a log field, which could expose sensitive values such as tokens and passwords even though printSanitizedVars was called on the line above. - Remove the raw 'vars' field from the Trace call in NewConfig - Fix printSanitizedVars to use structured hclog key/value logging instead of printf-style formatting
jmeridth
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewConfigwas logging the rawvarsmap as a Trace field directly after callingprintSanitizedVars. That meant any sensitive value — token, password, API key — invarswas emitted to the log in plaintext regardless of the sanitization helper running above it.This removes the raw
"vars", varsfield from the Trace call so only the redacted output fromprintSanitizedVarsis logged. A secondary fix switchesprintSanitizedVarsfrom printf-style to proper structuredhclogkey/value logging.