fix: ensure we're not persisting credentials after checkouts#122
Merged
fix: ensure we're not persisting credentials after checkouts#122
Conversation
Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds security hardening to GitHub Actions workflows by preventing credential persistence after checkout operations. The change ensures that Git credentials are not left accessible in the workspace after the initial checkout, reducing potential security risks.
- Adds
persist-credentials: falseto allactions/checkoutsteps across workflow files - Applies this security measure consistently to CI, linting, release, site deployment, and post-merge workflows
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/site.yml | Adds credential non-persistence to site deployment workflow checkout |
| .github/workflows/release.yml | Adds credential non-persistence to release workflow checkout |
| .github/workflows/post-merge.yml | Adds credential non-persistence to post-merge workflow checkout |
| .github/workflows/lint.yml | Adds credential non-persistence to lint workflow checkout |
| .github/workflows/ci.yml | Adds credential non-persistence to both CI and acceptance test job checkouts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds security configuration to GitHub Actions workflows by setting persist-credentials: false for checkout actions. This prevents GitHub credentials from being persisted in the Git configuration after repository checkout, reducing potential security risks from credential exposure.