chore: get go version file for workflows from go.mod#130
Merged
Conversation
Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub workflow files to derive the Go version from go.mod instead of hardcoding it in the workflow configurations. This ensures consistency between the Go version used in the project and the workflows, preventing potential build failures in GoReleaser and other tools.
- Replace hardcoded Go versions with
go-version-file: go.modparameter - Update CI, lint, and release workflows to use consistent Go version sourcing
- Eliminate manual version maintenance across multiple workflow files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Replace hardcoded Go version 1.24 with go-version-file: go.mod |
.github/workflows/lint.yml |
Replace go-version: stable with go-version-file: go.mod |
.github/workflows/ci.yml |
Replace hardcoded Go version ^1.23.4 with go-version-file: go.mod in both jobs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eddie-knight
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goreleaser will fail if we do not use the version we use in
go.modthis solution is the best in case we upgrade the version ingo.modagain and forget to update the workflow or Dependabot misses it to.Docs