chore: Update generator to create 'data/catalogs' by default#136
Merged
eddie-knight merged 5 commits intoprivateerproj:mainfrom Oct 13, 2025
Merged
chore: Update generator to create 'data/catalogs' by default#136eddie-knight merged 5 commits intoprivateerproj:mainfrom
eddie-knight merged 5 commits intoprivateerproj:mainfrom
Conversation
Signed-off-by: Eddie Knight <knight@linux.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the generator to place generated catalogs under data/catalogs by default and removes the simplifiedName helper from templates and code.
- Switch writeCatalogFile output directory to data/catalogs
- Remove simplifiedName helper function and its template FuncMap entry
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
jmeridth
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, fixed a bug in the filepaths for non-template files that are copied over.
Also, ignore
evaluation_results. We eventually need to fix the fact that "evaluation logs" are being created when not evaluating.corresponds to privateerproj/plugin-generator-templates#19