fix: set universal_binaries name_template to match build binary name#203
Merged
fix: set universal_binaries name_template to match build binary name#203
Conversation
## What
Set the name_template field on universal_binaries in .goreleaser.yaml to "pvtr" so the macOS universal binary matches the configured build binary name.
## Why
The universal_binaries name_template defaults to {{ .ProjectName }}, which resolves to the repo name "privateer". With replace: true, this overwrites the correctly named "pvtr" binary with one named "privateer", causing brew install to fail with ENOENT since the formula expects "pvtr".
## Notes
- A new release must be cut after this merges for the homebrew formula to work
- The archive filenames will still use "privateer" (e.g., privateer_Darwin_all.tar.gz) since ProjectName is unchanged — only the binary inside is affected
Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GoReleaser’s macOS universal binary naming so the produced universal binary matches the configured build/brew binary name (pvtr) instead of defaulting to the repository/project name (privateer), preventing Homebrew install failures.
Changes:
- Set
universal_binaries.name_templatetopvtrto avoid the default{{ .ProjectName }}name whenreplace: true. - Added inline documentation explaining why the override is necessary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set the name_template field on universal_binaries in .goreleaser.yaml to "pvtr" so the macOS universal binary matches the configured build binary name.
Why
The universal_binaries name_template defaults to {{ .ProjectName }}, which resolves to the repo name "privateer". With replace: true, this overwrites the correctly named "pvtr" binary with one named "privateer", causing
brew install privateerproj/tap/pvtrto fail withENOENT: No such file or directory - pvtrsince the formula expects a binary named "pvtr".Notes