Draft
Conversation
Avoid nil writer panic by creating list command in init with a Run that calls GetListCmd(writer) and SDK Run only when executing, after persistentPreRun has set writer. Flags applied via SetListCmdFlags. Made-with: Cursor
Made-with: Cursor
…inference - cmd/install.go: wire SDK GetInstallCmd with writer; build full URL from base or GitHub source+latest - internal/registry: PluginData with DownloadURL; GetPluginData fetches plugin-data JSON - internal/install: InferArtifactFilename (GOOS/GOARCH), InferGitHubReleaseBase, FromURL (GET + extract .tar.gz/.zip), FromImage stub Made-with: Cursor
Signed-off-by: Eddie Knight <knight@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocked by https://github.com/privateerproj/privateer-sdk/actions/runs/23104042993/job/67110129993?pr=175