Skip to content

feat: support pnpm's publishConfig #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privatenumber merged 5 commits into from
Mar 28, 2025
Merged

feat: support pnpm's publishConfig #120

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d9067c
feat: prefer publish config when defined
kwaa Mar 26, 2025
c7fd3fc
refactor: apply suggestion
kwaa Mar 26, 2025
d81e20a
fix(lint): remove trailing spaces
kwaa Mar 26, 2025
8bf484e
readme
privatenumber Mar 28, 2025
580e441
tests
privatenumber Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/utils/parse-package-json/get-export-entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
}

if (typeof exportMap === 'object') {
return Object.entries(exportMap).flatMap(([key, value]) => {

Check warning on line 67 in src/utils/parse-package-json/get-export-entries.ts

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest) 

Arrow function has a complexity of 12. Maximum allowed is 10
if (typeof value === 'string') {
const newProperty = propertyNeedsQuotes(key) ? `["${key}"]` : `.${key}`;
const baseEntry = {
Expand Down Expand Up @@ -142,7 +142,11 @@
}
};

export const getExportEntries = (packageJson: PackageJson) => {

Check warning on line 145 in src/utils/parse-package-json/get-export-entries.ts

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest) 

Arrow function has a complexity of 15. Maximum allowed is 10
// Prefer publishConfig when defined
// https://pnpm.io/package_json#publishconfig
packageJson = Object.assign(packageJson, packageJson.publishConfig ?? {});
Comment thread
kwaa marked this conversation as resolved.
Outdated

Check failure on line 149 in src/utils/parse-package-json/get-export-entries.ts

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest) 

Trailing spaces not allowed
const exportEntriesMap: Record<string, ExportEntry> = {};
const packageType = packageJson.type ?? 'commonjs';

Expand Down
Loading