Skip to content

add e2e tests for wallet service - #15

Merged
arlyon merged 7 commits into
arlyon/nextfrom
arlyon/wallets-service
Sep 26, 2025
Merged

add e2e tests for wallet service#15
arlyon merged 7 commits into
arlyon/nextfrom
arlyon/wallets-service

Conversation

@arlyon

@arlyon arlyon commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

blocked on a few things:

  • export is reporting 'No valid user session keys available'
  • the RPC endpoint tests are only passing with a 20% success rate (ish). Most of the time it reports that app id is not provided.
  • one of the tests (rpc send transactions) are ignored due to lacking funds
  • raw sign is ignored because the api reports that both solana and eth are 'not supported for this low level endpoint'
  • transactions are ignored because the openai schema reports 'base' as the only chain type which is not supported

@arlyon
arlyon force-pushed the arlyon/wallets-service branch from ec7dafe to 673cdd0 Compare September 12, 2025 10:27
@arlyon
arlyon marked this pull request as draft September 12, 2025 10:28
@arlyon arlyon changed the title implement all wallet tests add e2e tests for wallet serivce Sep 12, 2025
@arlyon
arlyon force-pushed the arlyon/wallets-service branch 3 times, most recently from 421a95c to 361bfb0 Compare September 12, 2025 12:32
@arlyon
arlyon marked this pull request as ready for review September 12, 2025 13:57
@arlyon arlyon changed the title add e2e tests for wallet serivce add e2e tests for wallet service Sep 12, 2025
Comment thread tests/wallets.rs
Comment thread tests/wallets.rs
Comment thread tests/wallets.rs Outdated
@arlyon
arlyon force-pushed the arlyon/wallets-service branch 5 times, most recently from de52b76 to ef63ba4 Compare September 15, 2025 23:48
Comment thread tests/wallets.rs
@socket-security

socket-security Bot commented Sep 18, 2025

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Sep 18, 2025

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
webpki-roots@1.0.2 has a License Policy Violation.

License: CDLA-Permissive-2.0 (webpki-roots-1.0.2/LICENSE)

License: CDLA-Permissive-2.0 (webpki-roots-1.0.2/Cargo.toml)

From: ?cargo/reqwest@0.12.23cargo/webpki-roots@1.0.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/webpki-roots@1.0.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Comment thread src/subclients.rs
Comment thread src/subclients.rs Outdated
Comment thread tests/wallets.rs Outdated
@arlyon
arlyon force-pushed the arlyon/wallets-service branch from 1d89c4c to 5db9abf Compare September 25, 2025 11:08

@jagtejsodhi jagtejsodhi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. One thought for another PR - we want to make sure we are testing flows that actually require an authorization context. i.e. rpc flows with a wallet that has an owner, updating a wallet that has an owner.

Comment thread tests/wallets.rs
@arlyon
arlyon force-pushed the arlyon/wallets-service branch from 5db9abf to 630ef5d Compare September 26, 2025 15:17
@arlyon
arlyon merged commit acad6af into arlyon/next Sep 26, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants