Mod : Estimation du prix de craft #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Je ves rajouter tout les inputs du jeu pour avoir un focus directement
Crédit : Tird, Reyem, Prout01, Aejii, Romarin
Crédit : Reyem, Aejii, Tird, Prout01, Romarin
ghost
suggested changes
Jan 8, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Le mod est sympa, je te suggère quand même quelques modifications.
- Esthétique (kamas)
- Technique pour le prochain gars (ou toi) qui devra regarder/modifier le code un jour
| let leftdiv = document.createElement("div"); | ||
| leftdiv.className = "estimationprix"; | ||
| leftdiv.id = "eprix"; | ||
| leftdiv.innerText = "Prix moyen du craft : " + this.formatNumber(totalprix) + " Kamas" + " (" + totalpods + " Pods)."; |
There was a problem hiding this comment.
Il serait peut-être + judicieux d'afficher l'icône Kamas, plutôt que le mot.
Tu peux faire quelque chose comme ça par exemple (à tester):
leftdiv.innerText = "Prix moyen du craft : " + this.formatNumber(totalprix) + " <img src='./assets/ui/icons/kamas.png' width='20px' height='16px' />" + " (" + totalpods + " Pods).";
Author
There was a problem hiding this comment.
Je vien de reupload le script, il faudra juste que tu jete un coup d'oeil niveau css pour mettre les 3 div sur la meme ligne stp
There was a problem hiding this comment.
Ta solution me semble étrange, je regarde ça ce week-end ;)
There was a problem hiding this comment.
En fait il faut simplement faire un .innerHTML plutôt qu'un .innerText
Il faudra juste que Broseidon jete un coup d'oeil niveau CSS
Merci Broseidon
Author
|
Aucun probleme contastater, pret a etre merge pour une beta |
Changement du nom de classe pour avoir le mod depuis le menu des métier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.