Non-vertical initial point and interpolated points to include 'inc' and 'azi'#21
Open
romanshor wants to merge 2 commits into
Open
Non-vertical initial point and interpolated points to include 'inc' and 'azi'#21romanshor wants to merge 2 commits into
romanshor wants to merge 2 commits into
Conversation
jcamiloangarita
requested changes
Jun 15, 2023
jcamiloangarita
left a comment
Collaborator
There was a problem hiding this comment.
thanks @romanshor for your contribution to this project. All changes seems to be fine, but there's still one 1 test failing (tests/test_well.py/test_get_point). Please check it out and add the respective changes to keep all the tests passing.
Just adding the 'inc' and 'azi' properties to the dictionary solves it.
25| self.assertTrue(p == {'md': 100, 'dl': 0.0, 'north': 0, 'east': 0, 'tvd': 100,
26| 'inc': 0, 'azi': 0,
27| 'pointType': 'interpolated', 'sectionType': 'vertical'})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing small changes: