-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatially-variant PSF/background reproducability #1053
Conversation
…ls.sh with new configs and eval script
Hey @jeff-regier, here is the code to reproduce the results/figures for the PSF paper. I haven't pulled from main yet so it's not ready to merge, just wanted to get this up as a draft so I don't forget. I made some changes to the metrics (mentioned in the first post). Can you let me know if these are fine to change, or if they may break someone else's results? I can create a new metric instead but didn't want to increase code bloat... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
+ Coverage 81.03% 82.13% +1.10%
==========================================
Files 23 23
Lines 2873 2978 +105
==========================================
+ Hits 2328 2446 +118
+ Misses 545 532 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aakash!
Mostly this PR is to reproduce the results and figures from the spatially-variant PSF paper.
I've made some changes to metrics, including:
SourceTypeAccuracy
to bin by magnitude instead of flux for consistency with other metricsFluxError
andGalaxyShapeError