Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatially-variant PSF/background reproducability #1053

Merged
merged 12 commits into from
Aug 3, 2024
Merged

Conversation

aakashdp6548
Copy link
Collaborator

Mostly this PR is to reproduce the results and figures from the spatially-variant PSF paper.

I've made some changes to metrics, including:

  • Changing SourceTypeAccuracy to bin by magnitude instead of flux for consistency with other metrics
  • Added binning by magnitude for FluxError and GalaxyShapeError

@aakashdp6548
Copy link
Collaborator Author

Hey @jeff-regier, here is the code to reproduce the results/figures for the PSF paper. I haven't pulled from main yet so it's not ready to merge, just wanted to get this up as a draft so I don't forget.

I made some changes to the metrics (mentioned in the first post). Can you let me know if these are fine to change, or if they may break someone else's results? I can create a new metric instead but didn't want to increase code bloat...

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 94.07407% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (c0645a3) to head (c795a3f).

Files Patch % Lines
bliss/__init__.py 12.50% 7 Missing ⚠️
bliss/encoder/metrics.py 99.20% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   81.03%   82.13%   +1.10%     
==========================================
  Files          23       23              
  Lines        2873     2978     +105     
==========================================
+ Hits         2328     2446     +118     
+ Misses        545      532      -13     
Flag Coverage Δ
unittests 82.13% <94.07%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aakashdp6548 aakashdp6548 marked this pull request as ready for review August 3, 2024 17:14
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aakash!

@jeff-regier jeff-regier merged commit 419e75d into master Aug 3, 2024
3 checks passed
@jeff-regier jeff-regier deleted the psf_case_study branch August 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants