Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up drawImage by reducing folding_threshold for galaxies with dim fluxes #1059

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

eshanjain1
Copy link
Collaborator

Every time drawImage() called, the folding_threshold (originally defaulted set to 0.995) is lowered to 0.95 if the average flux across bands is lower than a dim threshold. Use to speed up the drawing process.

@eshanjain1 eshanjain1 requested a review from jeff-regier August 16, 2024 16:22
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (295902b) to head (7299bd0).
Report is 1 commits behind head on master.

Files Patch % Lines
bliss/simulator/decoder.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   80.75%   80.76%   +0.01%     
==========================================
  Files          23       23              
  Lines        3061     3068       +7     
==========================================
+ Hits         2472     2478       +6     
- Misses        589      590       +1     
Flag Coverage Δ
unittests 80.76% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-regier jeff-regier merged commit bc88cfe into master Aug 16, 2024
3 checks passed
@jeff-regier jeff-regier deleted the ej/drawImage branch August 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants