Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing DC2 catalog generation updates #1062

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

timwhite0
Copy link
Collaborator

This PR contributes scripts and notebooks for generating an alternative version of our DC2 weak lensing catalog that includes all galaxies from the truth table with an r-band flux ≥ 50. This is a different approach from a previous PR in which we included all galaxies from the object-with-truth-match table (their true properties, not their measured properties). Both approaches are reasonable, and the resulting catalogs are not very different. The new, alternative version has ~1 million additional galaxies that were not in the object-with-truth-match table (e.g., because they were faint or blended).

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (1d20130) to head (7a124ca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files          23       23           
  Lines        3047     3047           
=======================================
  Hits         2475     2475           
  Misses        572      572           
Flag Coverage Δ
unittests 81.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timwhite0 timwhite0 requested a review from jeff-regier August 21, 2024 14:00
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 nJy may be too faint to allow for useful ellipticity estimates

@jeff-regier jeff-regier merged commit a41c818 into master Aug 21, 2024
3 checks passed
@jeff-regier jeff-regier deleted the tw/weak_lensing branch August 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants