Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-fix of old silent error (loss shape broadcast mismatch caused by extra dim of size 1) #1063

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

shreyasc30
Copy link
Collaborator

had to re-fix the gating error after recent changes, now convergence (or anything of size (b, h, w, 1)) is correctly squeezed before being gated even in the absence of n_sources

@shreyasc30 shreyasc30 requested a review from jeff-regier August 20, 2024 23:22
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (e9de7ce) to head (2eadbf5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   81.21%   81.22%   +0.01%     
==========================================
  Files          23       23              
  Lines        3045     3047       +2     
==========================================
+ Hits         2473     2475       +2     
  Misses        572      572              
Flag Coverage Δ
unittests 81.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-regier jeff-regier merged commit 1d20130 into master Aug 21, 2024
3 checks passed
@jeff-regier jeff-regier deleted the sc/weak_lensing_limited_galaxies branch August 21, 2024 00:12
@shreyasc30 shreyasc30 restored the sc/weak_lensing_limited_galaxies branch August 21, 2024 06:00
@shreyasc30 shreyasc30 deleted the sc/weak_lensing_limited_galaxies branch August 21, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants