-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weak lensing DC2 updates #1067
Weak lensing DC2 updates #1067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please try to remove the duplicated code before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 81.23% 81.25% +0.01%
==========================================
Files 23 23
Lines 3049 3051 +2
==========================================
+ Hits 2477 2479 +2
Misses 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
load_image_and_catalog
andgenerate_cached_data
. More efficient splitting of cached .pt files, and also more similar to the parent DC2 class than it was before.conv2d
to compute a weighted average of ellipticities from neighboring tiles. The previous approach, which was to estimate shear in each tile by taking the average of ellipticities in that tile, can be recovered by setting the size of the kernel in conv2d to 1. After a bit of exploration, it seems like a kernel size of 5 or 7 provides the best approximation of shear. This likely has implications for the "optimal" receptive field of our lensing encoder.ellipticity.ipynb
for an example.