Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weak lensing encoder shear updates #1072

Merged
merged 19 commits into from
Sep 18, 2024
Merged

weak lensing encoder shear updates #1072

merged 19 commits into from
Sep 18, 2024

Conversation

shreyasc30
Copy link
Collaborator

This PR makes the following weak-lensing and DC2-related changes:

  • allows users of the dc2 class to pull the entire set of PSF parameters for the truth match galaxies while maintaining flexibility to just use the median
  • subsequent updates to lensing dc2 to support the above workflow and expose PSFs in the tile catalog for use in image normalizers
  • Novel ResNet-like network structure for weak lensing, along with ResNet and ResNeXt blocks
  • Notably, the ability to have a residual connection via 1x1 convolution even when changing dimensions, which previous blocks did not have
  • conversion of shear_1 and shear_2 to Normal Factors and temporary removal of convergence from being predicted
  • subsequent updates to the encoder, plots, metrics, and config files to support the above

@shreyasc30 shreyasc30 marked this pull request as draft September 17, 2024 18:10
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.16%. Comparing base (0907a16) to head (a13010c).

Files with missing lines Patch % Lines
bliss/surveys/dc2.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   76.17%   76.16%   -0.02%     
==========================================
  Files          22       22              
  Lines        3077     3079       +2     
==========================================
+ Hits         2344     2345       +1     
- Misses        733      734       +1     
Flag Coverage Δ
unittests 76.16% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyasc30 shreyasc30 marked this pull request as ready for review September 17, 2024 18:53
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revision

@jeff-regier jeff-regier merged commit 6984255 into master Sep 18, 2024
3 checks passed
@jeff-regier jeff-regier deleted the sc/weak_lensing_lg branch September 18, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants