Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JIF results; Estimate ellipticity using second moments #1078

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

YicunDuanUMich
Copy link
Collaborator

  • update the code and notebook according to the master branch
  • add JIF results: you can find the results in jif_related folder
  • estimate ellipticity using second moments

@YicunDuanUMich YicunDuanUMich self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (0eb412b) to head (b2eaf02).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          22       22           
  Lines        3092     3092           
=======================================
  Hits         2355     2355           
  Misses        737      737           
Flag Coverage Δ
unittests 76.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jeff-regier jeff-regier merged commit bb0c5cb into master Oct 21, 2024
3 checks passed
@jeff-regier jeff-regier deleted the yd/dc2_cataloging_with_jif branch October 21, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants