-
Notifications
You must be signed in to change notification settings - Fork 101
feat: Use rich Panel for showing warning in train_test_split #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The display seems to work fine, many thanks!
sylvaincom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address failing tests
Coverage Report for backend
|
sylvaincom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-ai#1086) closes probabl-ai#1060 It is the alternative to probabl-ai#1060 using `rich`. I added a test to check that we can filter the warning since we are not using the usual `warnings` module. In the future, we could factor out the code in a utils to be sure that we can also transform the warnings into error.
closes #1060
It is the alternative to #1060 using
rich. I added a test to check that we can filter the warning since we are not using the usualwarningsmodule.In the future, we could factor out the code in a utils to be sure that we can also transform the warnings into error.