Skip to content

docs(api): Join sidebar sections #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomass-dev merged 2 commits into from
Jan 13, 2025
Merged

docs(api): Join sidebar sections #1094

thomass-dev merged 2 commits into from
Jan 13, 2025

Conversation

@augustebaum
Copy link
Contributor

@augustebaum augustebaum commented Jan 13, 2025 •
edited
Loading

Closes #1077

Screenshot:

2025-01-13T12_14_04_screenshot

@sylvaincom
Copy link
Contributor

sylvaincom commented Jan 13, 2025 •
edited
Loading

Hi @augustebaum I don't understand exactly what this PR does and how it closes issue #1077? Did you see my comment at #1077 (comment)? Or maybe I do a separate issue for my comment?

@augustebaum
Copy link
Contributor Author

augustebaum commented Jan 13, 2025 •
edited
Loading

Hi @augustebaum I don't understand exactly what this PR does and how it closes issue #1077? Did you see my comment at #1077 (comment)?

I read the suggested improvement ("Put it under the menu "ML Assistance"") as meaning "Remove the "Reporting for a single estimator"" heading; so now the sidebar has 2 sections instead of 3.

@sylvaincom
Copy link
Contributor

sylvaincom commented Jan 13, 2025

Ok, I create a new issue for my comment

@sylvaincom sylvaincom self-requested a review January 13, 2025 11:33
sylvaincom
sylvaincom approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sylvaincom sylvaincom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@thomass-dev
Copy link
Collaborator

thomass-dev commented Jan 13, 2025 •
edited
Loading

@augustebaum have you tried to build locally the documentation? If so, i can merge your PR.

thomass-dev
thomass-dev reviewed Jan 13, 2025
View reviewed changes
thomass-dev
thomass-dev requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@thomass-dev thomass-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick look at the dependencies.

@augustebaum
Copy link
Contributor Author

augustebaum commented Jan 13, 2025

@augustebaum have you tried to build locally the documentation? If so, i can merge your PR.

Yes

@thomass-dev thomass-dev merged commit db07089 into main Jan 13, 2025
8 of 9 checks passed
@thomass-dev thomass-dev deleted the 1077-join-sidebar-sections branch January 13, 2025 13:45
rouk1 pushed a commit that referenced this pull request Jan 14, 2025
@augustebaum @rouk1
docs(api): Join sidebar sections (#1094)
07b963f 
Closes #1077
waridrox pushed a commit to waridrox/skore that referenced this pull request Apr 15, 2025
@augustebaum
docs(api): Join sidebar sections (probabl-ai#1094)
732fa48 
Closes probabl-ai#1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomass-dev thomass-dev thomass-dev approved these changes

+1 more reviewer

@sylvaincom sylvaincom sylvaincom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@augustebaum augustebaum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: Improve API for Estimator report menu

5 participants

@augustebaum @sylvaincom @thomass-dev @auguste-probabl