-
Notifications
You must be signed in to change notification settings - Fork 101
chore: Move base.py outside from _estimator module #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage Report for backend
|
thomass-dev
previously approved these changes
Jan 14, 2025
Collaborator
|
Can you resolve the conflict @glemaitre before i merge? Thanks. |
Member
Author
|
Let me put the PR in draft for a couple of minutes, the time to move one test related to the base class. |
Member
Author
|
I'll ping when ready |
Member
Author
|
OK ready for review. I adapted one integration test to a unit tests. It should be fine now. |
thomass-dev
approved these changes
Jan 14, 2025
waridrox
pushed a commit
to waridrox/skore
that referenced
this pull request
Apr 15, 2025
It is a refactor to ease the review in probabl-ai#1091. It is only moving the file from `sklearn/_estimator/base.py` to `sklearn/_base.py` since some base class will be in common between the `EstimatorReport` and `CrossValidationReport`. In addition, I factor out an additional base class link to the help of the `*Report` class and the `_get_cached_response_values` that will also be used in the `CrossValidationReport`. So in short, there is no new code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a refactor to ease the review in #1091.
It is only moving the file from
sklearn/_estimator/base.pytosklearn/_base.pysince some base class will be in common between theEstimatorReportandCrossValidationReport.In addition, I factor out an additional base class link to the help of the
*Reportclass and the_get_cached_response_valuesthat will also be used in theCrossValidationReport.So in short, there is no new code here.