feat(project.put): Add note argument
#1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustebaum
force-pushed
the
note-commands-backend
branch
from
cbd9291 to
8da0ba8
Compare
thomass-dev
reviewed
Jan 14, 2025
augustebaum
force-pushed
the
add-note-argument-in-put
branch
from
460495b to
59991c9
Compare
augustebaum
force-pushed
the
add-note-argument-in-put
branch
from
59991c9 to
b2d4baf
Compare
Implementation notes: At first I used `set_note` directly, to delegate the type-checking process, but that meant touching the storage 2 times instead of 1.
augustebaum
force-pushed
the
add-note-argument-in-put
branch
from
b2d4baf to
1df42b1
Compare
thomass-dev
approved these changes
Jan 14, 2025
waridrox
pushed a commit
to waridrox/skore
that referenced
this pull request
Apr 15, 2025
Implementation notes: At first I used `set_note` directly, to delegate the type-checking process, but that meant touching the storage 2 times instead of 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation notes:
At first I used
set_notedirectly, to delegate the type-checking process, but that meant touching the storage 2 times instead of 1.Addresses part of #1041