feat: Rename estimator_reports_ to reports_ in CrossValidationReport
#1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
MarieSacksick
requested changes
Jun 26, 2025
Contributor
MarieSacksick
left a comment
MarieSacksick
left a comment
There was a problem hiding this comment.
Mostly ok for me, just one addition I don't understand.
| y_pred=y_pred, | ||
| report_type="comparison-estimator", | ||
| estimators=[report.estimator_ for report in self._parent.reports_], | ||
| estimator_names=self._parent.report_names_, |
Contributor
There was a problem hiding this comment.
this doesn't output estimator names but the cross validation report names if given when building the - can you remove this line please?
This is already handled, if you check this code:
# %%
from sklearn.datasets import make_classification
from sklearn.ensemble import HistGradientBoostingClassifier
from skore import ComparisonReport, CrossValidationReport
# %%
X, y = make_classification(n_samples=1000, n_features=20, random_state=42)
# %%
cv_rep1 = CrossValidationReport(
HistGradientBoostingClassifier(),
X,
y,
)
# %%
cv_rep2 = CrossValidationReport(
HistGradientBoostingClassifier(learning_rate=1),
X,
y,
)
# %%
comp_named = ComparisonReport(
{"cv_1": cv_rep1, "cv_2": cv_rep2},
)
# %%
comp_named.metrics.roc().plot()
| for estimator_report in report.estimator_reports_ | ||
| for estimator_report in report.reports_ | ||
| ], | ||
| estimator_names=self._parent.report_names_, |
Contributor
There was a problem hiding this comment.
just like above, can you remove this line please?
| *, | ||
| report_type: ReportType, | ||
| estimators: Sequence[BaseEstimator], | ||
| estimator_names: list[str], |
Contributor
There was a problem hiding this comment.
why do you need this new parameter in this function? I don't see where it's used.
Contributor
|
Some conflicts need to be solved here. |
Contributor
|
Superseded by #2033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1760
Hi @MarieSacksick , @glemaitre !
I've renamed
estimator_reports_toreports_throughout theCrossValidationReportclass, aligning the API withComparisonReport.Solved the pickling error by introducing
allow_nested = Falseinside inprogress_decoratorof function_compute_metric_scoresinmetrics_acessor.pyandallow_nested = Truein_progress_bar.py.Add the requested unittest in
test_progress_bar.py.If I missed something kindly let me know
Thank You !