Skip to content

Conversation

@MatthieuLoustaunau
Copy link
Contributor

Closes #1446

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

Caution

Some commits in the pull request are not signed, or GitHub is not able to verify the signature.
Please sign all your commits; you can find more information here.
Please note that when you activate commit signing, you'll need to retroactively sign your previous commits.

@MatthieuLoustaunau
Copy link
Contributor Author

MatthieuLoustaunau commented Jul 6, 2025

missing :

  • Favorability appears twice with data_source="all"
  • doc to update.

@MarieSacksick
Copy link
Contributor

@MatthieuLoustaunau, do you want to finish this PR, or should we take it from here?

@MatthieuLoustaunau
Copy link
Contributor Author

I plan to come back at this during the next week, as I will have some spare time. If I cannot finish within 2 weeks I let you take over.

@MatthieuLoustaunau MatthieuLoustaunau force-pushed the add-all-to-data-sources-in-report-summary branch from ed39f5c to 484ad6f Compare October 17, 2025 22:03
@MatthieuLoustaunau MatthieuLoustaunau marked this pull request as ready for review October 17, 2025 22:12
@MarieSacksick MarieSacksick changed the title feat enable all to data_source of metrics summarize feat: Enable all to data_source of metrics summarize Oct 20, 2025
Copy link
Contributor

@MarieSacksick MarieSacksick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doctests are failing, could you have a look at why please? It looks like it comes from the new docstring.
Also, could you keep only one summarize function please, and extend the public one (summarize), instead of creating a new private (_summarize) one? Thanks!

@MatthieuLoustaunau
Copy link
Contributor Author

@MarieSacksick I have removed the _summarize method, hopefully avoiding confusion with summarize.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Documentation preview @ 3bd557e

Copy link
Contributor

@MarieSacksick MarieSacksick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a doctest that does not pass, could you fix it please? You can run it locally by doing: cd skore && pytest.
And also, could you add a test please? (in the folder /skore/skore/tests/unit/displays/metrics_summary/test_estimator.py)

@auguste-probabl auguste-probabl changed the title feat: Enable all to data_source of metrics summarize feat(skore): Add data_source="all" option to EstimatorReport.metrics.summarize Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py240100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py35294%93, 117
   metrics_accessor.py179398%167, 247, 1209
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py90100% 
   data_accessor.py45393%134, 137, 140
   feature_importance_accessor.py240100% 
   metrics_accessor.py183199%242
   report.py135199%488
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py66198%82
   feature_importance_accessor.py168298%258–259
   metrics_accessor.py360598%330, 399, 403, 418, 453
   report.py165298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py98693%61–62, 224–226, 230
   utils.py770100% 
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py185199%706
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%92, 100, 122, 230
   feature_importance_coefficients_display.py712170%116–119, 121, 140, 146–152, 155, 161–165, 170–171
   metrics_summary_display.py80100% 
   precision_recall_curve.py281598%455, 555, 559, 619, 751
   prediction_error.py227597%179, 186, 422, 505, 705
   roc_curve.py294897%387, 510, 515, 616, 621, 625, 694, 834
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py27196%40
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py211242%30, 35–39, 42–43, 46–47, 58, 60
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py75198%120
   widget.py1870100% 
TOTAL406311697% 

Tests Skipped Failures Errors Time
1105 5 💤 0 ❌ 0 🔥 4m 22s ⏱️

Copy link
Contributor

@MarieSacksick MarieSacksick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, thanks @MatthieuLoustaunau and @auguste-probabl!

@MarieSacksick MarieSacksick added this pull request to the merge queue Nov 7, 2025
Merged via the queue into probabl-ai:main with commit 24e2a2b Nov 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enh(skore): Enable data_source="all" in metrics accessor

3 participants