-
Notifications
You must be signed in to change notification settings - Fork 101
docs(getting started): Change dataset to synthetic #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(getting started): Change dataset to synthetic #1941
Conversation
0458060 to
78684a1
Compare
|
Did you use an LLM to generate your PR? Please check the documentation. The challenge is to understand the issue, and to be able to easily contribute in future. |
78684a1 to
f5df837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the PR is sufficient to resolve the issue. @sylvaincom can you take a look? Thanks!
|
Hi, I agree with @thomass-dev: this feels LLM generated and you did not take into account the description of the parent issue, especially the shown plots
|
|
@sylvaincom I’ve updated the example to use 10,000 samples with
|
- Use make_classification with n_samples=10_000 and multiclass parameters - Update estimator to LogisticRegression for better demonstration Fixes probabl-ai#1861
f5df837 to
b78d496
Compare
|
You do not seem to understand what you're doing: you're calling |
- Change rf to lr and rf_report to lr_report for consistency
glemaitre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of remarks.
thomass-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @auguste-probabl for the follow-up, LGTM now.




Summary
load_breast_cancerwithmake_classificationusing challenging parametersevaluation tools
Changes
make_classificationwith parameters: n_samples=1000, n_features=20, n_informative=10,n_redundant=10, n_clusters_per_class=1, random_state=42
Why this improves the example
The synthetic dataset provides more realistic performance metrics (ROC-AUC ~0.90 vs ~0.99) and
clearer differences between models, making it better for educational purposes, and demonstrating
When different models/techniques matter.
Test plan
Fixes #1861