Skip to content

Conversation

@thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Aug 17, 2025

Change the behavior of some CrossValidationReportPayload properties to reduce the memory footprint:

  • splits, to sent the train/test distribution on 200 buckets maximum,
  • classes, to sent the classes distribution on 200 buckets maximum,
  • dataset_size, to sent the size of the whole dataset.

@thomass-dev thomass-dev force-pushed the skore-cross-validation branch 2 times, most recently from 8cd0b8b to 6026a30 Compare August 17, 2025 21:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2025

Documentation preview @ e4a6a08

@thomass-dev thomass-dev force-pushed the skore-cross-validation branch from 72f8e42 to 6026a30 Compare August 17, 2025 22:20
@thomass-dev thomass-dev force-pushed the skore-cross-validation branch 3 times, most recently from e051013 to 923692c Compare August 18, 2025 11:50
@probabl-ai probabl-ai deleted a comment from github-actions bot Aug 18, 2025
@probabl-ai probabl-ai deleted a comment from github-actions bot Aug 18, 2025
@probabl-ai probabl-ai deleted a comment from github-actions bot Aug 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%92, 111
   metrics_accessor.py178398%173, 253, 1215
   report.py1060100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py70100% 
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py580100% 
   feature_importance_accessor.py144298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py70100% 
   style.py290100% 
   utils.py141795%59, 83–85, 89, 344–345
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py183199%682
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%91, 99, 121, 229
   feature_importance_display.py672168%92, 115–116, 118, 136–140, 142–149, 152–154, 156
   metrics_summary_display.py90100% 
   precision_recall_curve.py278598%459, 559, 563, 623, 743
   prediction_error.py225597%181, 188, 424, 507, 687
   roc_curve.py290897%389, 512, 517, 618, 623, 627, 696, 818
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py270100% 
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py740100% 
   widget.py165696%436, 439–441, 525–526
TOTAL393911397% 

Tests Skipped Failures Errors Time
1039 5 💤 0 ❌ 0 🔥 4m 0s ⏱️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py19194%35
   protocol.py260100% 
skore-hub-project/src/skore_hub_project/artefact
   __init__.py20100% 
   artefact.py360100% 
   serializer.py280100% 
   upload.py36488%169, 171–172, 174
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py19194%26
   logout.py50100% 
   token.py180100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   api.py470100% 
   client.py600100% 
skore-hub-project/src/skore_hub_project/media
   __init__.py60100% 
   data.py42295%26, 28
   feature_importance.py460100% 
   media.py180100% 
   model.py150100% 
   performance.py550100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py320100% 
   brier_score.py320100% 
   log_loss.py340100% 
   metric.py49197%23
   precision.py600100% 
   r2.py320100% 
   recall.py600100% 
   rmse.py340100% 
   roc_auc.py340100% 
   timing.py87495%51–52, 113–114
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py82297%247, 275
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py72297%210, 251
   estimator_report.py200100% 
   report.py480100% 
TOTAL11671798% 

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 1m 8s ⏱️

@rouk1

This comment was marked as outdated.

@rouk1

This comment was marked as resolved.

@glemaitre
Copy link
Member

glemaitre commented Aug 25, 2025

adding a groups kwarg to CrossValidationReport constructor

Adding groups as a kwarg in the constructor should be given some thoughts. We are deprecating this behaviour in scikit-learn: (cf. https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.cross_validate.html and the groups) parameter and moving having a params that is a dict taking whatever metadata that should be routed.

In short, it would mean that we can have something like:

CrossValidationReport(
    estimator=model,
    X=X,
    y=y,
    cv=MyCVSplitter().set_split_request(metadata=True),
    params={"metadata": np.random.randn(y.shape[0])}
)

@thomass-dev thomass-dev changed the title feat(skore): Put CrossValidationReport to a project feat(skore): Put/get/summarize CrossValidationReport Sep 4, 2025
@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Sep 8, 2025

I'm taking back control of this PR and will split the work in several.

@thomass-dev thomass-dev changed the title feat(skore): Put/get/summarize CrossValidationReport feat(skore-hub-project): Change the behavior of some CrossValidationReportPayload properties Sep 10, 2025
@thomass-dev thomass-dev marked this pull request as ready for review September 10, 2025 08:01
@thomass-dev thomass-dev merged commit 80f0ea2 into main Sep 10, 2025
39 checks passed
@thomass-dev thomass-dev deleted the skore-cross-validation branch September 10, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants