-
Notifications
You must be signed in to change notification settings - Fork 101
feat(skore-hub-project): Change the behavior of some CrossValidationReportPayload properties
#1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8cd0b8b to
6026a30
Compare
72f8e42 to
6026a30
Compare
e051013 to
923692c
Compare
Coverage Report for |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| File | Stmts | Miss | Cover | Missing |
|---|---|---|---|---|
| skore-hub-project/src/skore_hub_project | ||||
| __init__.py | 19 | 1 | 94% | 35 |
| protocol.py | 26 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/artefact | ||||
| __init__.py | 2 | 0 | 100% | |
| artefact.py | 36 | 0 | 100% | |
| serializer.py | 28 | 0 | 100% | |
| upload.py | 36 | 4 | 88% | 169, 171–172, 174 |
| skore-hub-project/src/skore_hub_project/authentication | ||||
| __init__.py | 0 | 0 | 100% | |
| login.py | 19 | 1 | 94% | 26 |
| logout.py | 5 | 0 | 100% | |
| token.py | 18 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/client | ||||
| __init__.py | 0 | 0 | 100% | |
| api.py | 47 | 0 | 100% | |
| client.py | 60 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/media | ||||
| __init__.py | 6 | 0 | 100% | |
| data.py | 42 | 2 | 95% | 26, 28 |
| feature_importance.py | 46 | 0 | 100% | |
| media.py | 18 | 0 | 100% | |
| model.py | 15 | 0 | 100% | |
| performance.py | 55 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/metric | ||||
| __init__.py | 10 | 0 | 100% | |
| accuracy.py | 32 | 0 | 100% | |
| brier_score.py | 32 | 0 | 100% | |
| log_loss.py | 34 | 0 | 100% | |
| metric.py | 49 | 1 | 97% | 23 |
| precision.py | 60 | 0 | 100% | |
| r2.py | 32 | 0 | 100% | |
| recall.py | 60 | 0 | 100% | |
| rmse.py | 34 | 0 | 100% | |
| roc_auc.py | 34 | 0 | 100% | |
| timing.py | 87 | 4 | 95% | 51–52, 113–114 |
| skore-hub-project/src/skore_hub_project/project | ||||
| __init__.py | 0 | 0 | 100% | |
| project.py | 82 | 2 | 97% | 247, 275 |
| skore-hub-project/src/skore_hub_project/report | ||||
| __init__.py | 3 | 0 | 100% | |
| cross_validation_report.py | 72 | 2 | 97% | 210, 251 |
| estimator_report.py | 20 | 0 | 100% | |
| report.py | 48 | 0 | 100% | |
| TOTAL | 1167 | 17 | 98% | |
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 134 | 0 💤 | 0 ❌ | 0 🔥 | 1m 8s ⏱️ |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Adding In short, it would mean that we can have something like: CrossValidationReport(
estimator=model,
X=X,
y=y,
cv=MyCVSplitter().set_split_request(metadata=True),
params={"metadata": np.random.randn(y.shape[0])}
) |
This reverts commit 39c59a5.
This reverts commit 2c9928e.
skore-hub-project/src/skore_hub_project/report/cross_validation_report.py
Outdated
Show resolved
Hide resolved
skore-hub-project/src/skore_hub_project/report/cross_validation_report.py
Outdated
Show resolved
Hide resolved
…n_report.py Co-authored-by: Thomas S. <[email protected]>
CrossValidationReport to a projectCrossValidationReport
skore-hub-project/tests/unit/report/test_cross_validation_report.py
Outdated
Show resolved
Hide resolved
|
I'm taking back control of this PR and will split the work in several. |
CrossValidationReportCrossValidationReportPayload properties
Change the behavior of some
CrossValidationReportPayloadproperties to reduce the memory footprint:splits, to sent the train/test distribution on 200 buckets maximum,classes, to sent the classes distribution on 200 buckets maximum,dataset_size, to sent the size of the whole dataset.