Skip to content

Conversation

@auguste-probabl
Copy link
Contributor

@auguste-probabl auguste-probabl commented Aug 27, 2025

Remove report_names_.

Closes #1577

Supersedes #1961

Co-authored-by: Himanshu Sharma [email protected]

@auguste-probabl
Copy link
Contributor Author

auguste-probabl commented Aug 27, 2025

Notice that we often have to write weird statements like list(report.reports_.values())[0]. Personally I don't think one phrasing is better than the other, so I would just not touch it.

@auguste-probabl

This comment was marked as resolved.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Documentation preview @ 68b9348

@auguste-probabl auguste-probabl changed the title feat(ComparisonReport): Make reports_ a dict instead of a dict feat(ComparisonReport): Make reports_ a dict instead of a list Aug 27, 2025
@auguste-probabl auguste-probabl force-pushed the push-slmsvxmwrltp branch 2 times, most recently from d08329f to 7bbf04e Compare September 9, 2025 14:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%90, 109
   metrics_accessor.py178398%173, 253, 1215
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py70100% 
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py580100% 
   feature_importance_accessor.py144298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py70100% 
   style.py290100% 
   utils.py141795%59, 83–85, 89, 344–345
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py183199%682
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%91, 99, 121, 229
   feature_importance_display.py672168%92, 115–116, 118, 136–140, 142–149, 152–154, 156
   metrics_summary_display.py90100% 
   precision_recall_curve.py278598%459, 559, 563, 623, 743
   prediction_error.py225597%181, 188, 424, 507, 687
   roc_curve.py290897%389, 512, 517, 618, 623, 627, 696, 818
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py270100% 
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py740100% 
   widget.py165696%436, 439–441, 525–526
TOTAL394011397% 

Tests Skipped Failures Errors Time
1039 5 💤 0 ❌ 0 🔥 4m 11s ⏱️

@thomass-dev thomass-dev changed the title feat(ComparisonReport): Make reports_ a dict instead of a list feat(ComparisonReport)!: Make reports_ a dict instead of a list Sep 9, 2025
@thomass-dev thomass-dev merged commit c3d5649 into probabl-ai:main Sep 10, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ComparisonReport): Give access to sub-estimators through a dict rather than lists

2 participants