-
Notifications
You must be signed in to change notification settings - Fork 101
feat(ComparisonReport)!: Make reports_ a dict instead of a list
#1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomass-dev
merged 4 commits into
probabl-ai:main
from
auguste-probabl:push-slmsvxmwrltp
Sep 10, 2025
Merged
feat(ComparisonReport)!: Make reports_ a dict instead of a list
#1986
thomass-dev
merged 4 commits into
probabl-ai:main
from
auguste-probabl:push-slmsvxmwrltp
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Notice that we often have to write weird statements like |
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
Contributor
reports_ a dict instead of a dictreports_ a dict instead of a list
Remove `report_names_`. Co-authored-by: Himanshu Sharma <[email protected]>
d08329f to
7bbf04e
Compare
7bbf04e to
68b9348
Compare
Contributor
reports_ a dict instead of a listreports_ a dict instead of a list
thomass-dev
reviewed
Sep 9, 2025
thomass-dev
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
report_names_.Closes #1577
Supersedes #1961
Co-authored-by: Himanshu Sharma [email protected]