Skip to content

Conversation

@rouk1
Copy link
Contributor

@rouk1 rouk1 commented Sep 1, 2025

This PR moves TableReportDisplay._to_json to skore-hub-project where it belongs.
Also plotting during serialization is done with an offscreen backend and an extract of the data is serilaized.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%92, 111
   metrics_accessor.py178398%173, 253, 1215
   report.py1060100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py70100% 
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py580100% 
   feature_importance_accessor.py144298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py70100% 
   style.py290100% 
   utils.py141795%59, 83–85, 89, 344–345
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py183199%682
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%91, 99, 121, 229
   feature_importance_display.py672168%92, 115–116, 118, 136–140, 142–149, 152–154, 156
   metrics_summary_display.py90100% 
   precision_recall_curve.py278598%459, 559, 563, 623, 743
   prediction_error.py225597%181, 188, 424, 507, 687
   roc_curve.py290897%389, 512, 517, 618, 623, 627, 696, 818
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py16193%79
   high_class_imbalance_warning.py170100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py21195%73
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py270100% 
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py740100% 
   widget.py165696%436, 439–441, 525–526
TOTAL393311497% 

Tests Skipped Failures Errors Time
1029 5 💤 0 ❌ 0 🔥 4m 2s ⏱️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Documentation preview @ b19a1eb

@thomass-dev thomass-dev self-requested a review September 1, 2025 15:34
Copy link
Collaborator

@thomass-dev thomass-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that i can review 🙈 .

@thomass-dev thomass-dev changed the title feat: Table report's json serialization update feat(skore, skore-hub-project): Table report's json serialization update Sep 5, 2025
@thomass-dev thomass-dev changed the title feat(skore, skore-hub-project): Table report's json serialization update feat(skore,skore-hub-project): Table report's json serialization update Sep 5, 2025
@thomass-dev thomass-dev changed the title feat(skore,skore-hub-project): Table report's json serialization update feat(skore,skore-hub-project): Update how table report is sent to the hub Sep 5, 2025
@thomass-dev thomass-dev changed the title feat(skore,skore-hub-project): Update how table report is sent to the hub feat(skore-hub-project): Update how table report is sent to the hub Sep 5, 2025
@rouk1 rouk1 marked this pull request as ready for review September 5, 2025 13:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py19194%35
   protocol.py260100% 
skore-hub-project/src/skore_hub_project/artefact
   __init__.py20100% 
   artefact.py360100% 
   serializer.py280100% 
   upload.py36488%169, 171–172, 174
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py19194%26
   logout.py50100% 
   token.py180100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   api.py470100% 
   client.py600100% 
skore-hub-project/src/skore_hub_project/media
   __init__.py60100% 
   data.py42295%26, 28
   feature_importance.py460100% 
   media.py180100% 
   model.py150100% 
   performance.py550100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py320100% 
   brier_score.py320100% 
   log_loss.py340100% 
   metric.py49197%23
   precision.py600100% 
   r2.py320100% 
   recall.py600100% 
   rmse.py340100% 
   roc_auc.py340100% 
   timing.py87495%51–52, 114–115
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py82297%247, 275
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py61395%144–145, 229
   estimator_report.py200100% 
   report.py480100% 
TOTAL11561898% 

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 1m 6s ⏱️

@thomass-dev thomass-dev merged commit 73f3c52 into probabl-ai:main Sep 5, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants