Skip to content

feat(skore-hub-project): Remove unused media from CrossValidationReportPayload #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

feat(skore-hub-project): Remove unused media from CrossValidationReportPayload #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions skore-hub-project/src/skore_hub_project/report/cross_validation_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@
from skore_hub_project.artefact import CrossValidationReportArtefact
from skore_hub_project.media import (
EstimatorHtmlRepr,
PrecisionRecallTest,
PrecisionRecallTrain,
PredictionErrorTest,
PredictionErrorTrain,
RocTest,
RocTrain,
)
from skore_hub_project.media.media import Media
from skore_hub_project.metric import (
Expand Down Expand Up @@ -129,18 +123,7 @@ class CrossValidationReportPayload(ReportPayload):
PredictTimeTrainStd,
),
)
MEDIAS: ClassVar[tuple[Media, ...]] = cast(
tuple[Media, ...],
(
EstimatorHtmlRepr,
PrecisionRecallTest,
PrecisionRecallTrain,
PredictionErrorTest,
PredictionErrorTrain,
RocTest,
RocTrain,
),
)
MEDIAS: ClassVar[tuple[Media, ...]] = cast(tuple[Media, ...], (EstimatorHtmlRepr,))

report: CrossValidationReport = Field(repr=False, exclude=True)

Expand Down
12 changes: 1 addition & 11 deletions skore-hub-project/tests/unit/report/test_cross_validation_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
from skore_hub_project.artefact.serializer import Serializer
from skore_hub_project.media import (
EstimatorHtmlRepr,
PrecisionRecallTest,
PrecisionRecallTrain,
RocTest,
RocTrain,
)
from skore_hub_project.metric import (
AccuracyTestMean,
Expand Down Expand Up @@ -202,13 +198,7 @@ def test_metrics(self, payload):
]

def test_related_items(self, payload):
assert list(map(type, payload.related_items)) == [
EstimatorHtmlRepr,
PrecisionRecallTest,
PrecisionRecallTrain,
RocTest,
RocTrain,
]
assert list(map(type, payload.related_items)) == [EstimatorHtmlRepr]

@mark.usefixtures("monkeypatch_routes")
def test_model_dump(self, small_cv_binary_classification, payload):
Expand Down
Loading