-
Notifications
You must be signed in to change notification settings - Fork 101
fix(skore): Document plot via explicit implementation #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
thomass-dev
reviewed
Sep 10, 2025
Co-authored-by: Thomas S. <[email protected]>
| This decorator: | ||
| 1. Applies default style settings | ||
| 2. Executes `plot_func` | ||
| 3. Applies `tight_layout` |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it apply tight layout?
Contributor
|
I can confirm that this solves the issue, using the reproducer given here |
auguste-probabl
approved these changes
Sep 11, 2025
Contributor
auguste-probabl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, awesome!
thomass-dev
approved these changes
Sep 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Follow-up on #2027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixing #1996
This PR implement a specialized
plotmethod for each display. It allows to get the proper documentation that was broken when using amixinthat overwrite it.This approach is simpler than trying to overwrite the name function, signature, and documentation of the dispatch plotting function. It should be easier to maintain.
While implementing this PR, I also fix the following:
mixininbase.pyand create aDisplayMixinsince all specialized displays will inherit from all those mixins.ConfusionMatrixDisplaybut it will need more work.FeatureImportanceDisplaybut it also need some more work.