Skip to content

Conversation

@thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Sep 10, 2025

Closes #2024.

@thomass-dev thomass-dev force-pushed the skore-test-model-explorer-widget-with-skore-local-project branch from c40fb8f to f135c1d Compare September 10, 2025 13:43
@thomass-dev thomass-dev changed the title chore(skore): Naively testing ModelExplorerWidget with skore-local-project in a notebook chore(skore): Add a naive test ModelExplorerWidget with skore-local-project in a notebook Sep 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025

Documentation preview @ 58069d3

@thomass-dev thomass-dev marked this pull request as draft September 10, 2025 14:04
@thomass-dev thomass-dev force-pushed the skore-test-model-explorer-widget-with-skore-local-project branch from bebbcee to 5c0d4f7 Compare September 10, 2025 14:05
@thomass-dev thomass-dev marked this pull request as ready for review September 10, 2025 14:10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%90, 109
   metrics_accessor.py178398%173, 253, 1215
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py90100% 
   data_accessor.py45393%128, 131, 134
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py580100% 
   feature_importance_accessor.py144298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py102793%61–62, 200, 224–226, 230
   utils.py770100% 
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py185199%706
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%92, 100, 122, 230
   feature_importance_display.py672168%88, 121–122, 124, 142–146, 148–155, 158–160, 162
   metrics_summary_display.py80100% 
   precision_recall_curve.py280598%455, 555, 559, 619, 751
   prediction_error.py227597%179, 186, 422, 505, 705
   roc_curve.py292897%385, 508, 513, 614, 619, 623, 692, 832
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py27196%40
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py740100% 
   widget.py165696%436, 439–441, 525–526
TOTAL399611797% 

Tests Skipped Failures Errors Time
1061 5 💤 0 ❌ 0 🔥 4m 18s ⏱️

@thomass-dev thomass-dev force-pushed the skore-test-model-explorer-widget-with-skore-local-project branch from 5c0d4f7 to 58069d3 Compare September 10, 2025 14:16
@thomass-dev thomass-dev changed the title chore(skore): Add a naive test ModelExplorerWidget with skore-local-project in a notebook chore(skore): Add a naive ModelExplorerWidget test with skore-local-project in a notebook Sep 10, 2025
glemaitre
glemaitre previously approved these changes Sep 15, 2025
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment to recall what we try to do with this test ;)

It is an unusual one.

@glemaitre glemaitre enabled auto-merge September 15, 2025 09:43
@thomass-dev thomass-dev merged commit c87f9c4 into main Sep 15, 2025
31 checks passed
@thomass-dev thomass-dev deleted the skore-test-model-explorer-widget-with-skore-local-project branch September 15, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(skore): Test ModelExplorerWidget with skore-local-project and a notebook

3 participants